Fix for the issue 1005 #1488
Merged
Fix for the issue 1005 #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(https://github.com/mermaid-js/mermaid/issues/1005) A new attribute 'order' has been introduced in the task which records the serial number of task in the script. In ganttRenderer.js, the tasks are sorted by stratTime attribute. The function which calculates 'y' for task rectangles, lables etc. has been modified to correctly position it.
|
@GDFaber |
|
Hi @abhijeet-pathak, thank you for looking into this. Can you provide a unit test in the specs as well? It will be harder to break the order accidentally if there is a test running frequently. |
Sure @GDFaber . |
|
@GDFaber |
knsv
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(mermaid-js/mermaid-live-editor#1174)
A new attribute 'order' has been introduced in the task which records
the serial number of task in the script.
In ganttRenderer.js, the tasks are sorted by stratTime attribute.
The function which calculates 'y' for task rectangles, labels etc.
has been modified to correctly position it.
📑 Summary
Generate the SVG elements in the ascending order of datetime of the tasks.
Resolves mermaid-js/mermaid-live-editor#1174
📏 Design Decisions
An 'order' attribute has been added in the ganttDb to maintain the order in which tasks are added.
While creating the SVG rects and other assets, datetime order is considered and tasks are sorted accordingly.
📋 Tasks
Make sure you
developbranch